Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable "push and create PR" #5278

Merged
merged 4 commits into from
Oct 23, 2024
Merged

fix: enable "push and create PR" #5278

merged 4 commits into from
Oct 23, 2024

Conversation

ndom91
Copy link
Contributor

@ndom91 ndom91 commented Oct 23, 2024

☕️ Reasoning

  • Add "Push and Create PR" funcitonality back

🧢 Changes

  • Works by showing the "Create Pull Request" button in the series header early (i.e. before series has been pushed).
    • If the user presses it, the PrDetailsModal opens as normal, but the options there are then "Push and Create Pull Request" / "Push and Create Draft Pull Request", which upon clicking then does what it says on the tin.

Copy link

vercel bot commented Oct 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
gitbutler-web ⬜️ Skipped (Inspect) Oct 23, 2024 4:04pm

@ndom91 ndom91 force-pushed the feat-add-push-and-create-pr branch from 061bf4c to d4b60d0 Compare October 23, 2024 15:50
@ndom91 ndom91 marked this pull request as ready for review October 23, 2024 15:54
@krlvi krlvi merged commit 2988c75 into master Oct 23, 2024
14 checks passed
@krlvi krlvi deleted the feat-add-push-and-create-pr branch October 23, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants